WIP Enav version - move S104/S111 logic into S100 class

princessmittens commented 2 years ago

Added types to params in S104, S100 and S111 classes
Added _populate_group_metadata function in S100
Added _create_positioning_group function in S100
Moved logic for _update_feature_metadata into S100 class
Expanded on init functions in S111/S104 to have hardcoded values that are custom to each class (passed into S100 constructor)
Added s100_util file for utility methods and an attribute class

Note that there is a descrepancy between my branch and the eastBoundLatitude, could you take a look at this? I'm not sure why this is the case but I thought maybe you pushed a fix for it while I was working on the branch.

glmcr commented 2 years ago

It seems that the WIP in the title does not prevent a PR to be merged as in gitlab.

princessmittens commented 2 years ago

No, I don't think it's a thing in github. Different I guess!

glmcr commented 2 years ago

No, I don't think it's a thing in github. Different I guess!

Not sure but I think that we have to use the "convert to draft" button for getting the same gitlab "WIP" thing effect

princessmittens commented 2 years ago

I think this is ready to merge if the changes have been reviewed?

DFO-CHS-Dynamic-Hydrographic-Products / IWLS_pygeoapi

WIP Enav version - move S104/S111 logic into S100 class #8