search

DFO-Ocean-Navigator / Navigator-Installer

Home for the installation scripts/data for the Ocean Navigator.
MIT License
0 stars 1 forks source link

Update install instructions #23

Closed jmunroe closed 3 years ago

jmunroe commented 3 years ago

I just was going through the install instructions again on as given in the README.md on clean Ubuntu 18.04 LTS install.

At the yarn install step got the following error:

error chalk@4.1.0: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.16.0" error Found incompatible module.

Do we need to update the instructions to require node >= 10?

dwayne-hart commented 3 years ago

This should be resolved with pull request 24. node was updated from v8.16.0 to v12.18.4.

jmunroe commented 3 years ago

Thanks. Lots of changes in that PR. It looks though that now the miniconda install has the path "/mnt/ramdisk/tools/" baked in (instead of the the expected "/home/buildadm/tools") which is causing things to break.

dwayne-hart commented 3 years ago

Pull request 25 removes the provided version of Miniconda. The bin/configure.sh script removes any existing Miniconda version, then performs a fresh installation of Miniconda and the virtual environments that comprise the Ocean Navigator toolchain.

jmunroe commented 3 years ago

Good choice. I think this is the right solution (as matches what we are doing with npm).

Should the whole tools/miniconda directory be now removed from this repo? Also, did you want to pull Miniconda*.sh from a "official" url rather than including it within this repo?

dwayne-hart commented 3 years ago

Pull request 26 brings it inline with how we are pulling in npm as @jmunroe requested.

dwayne-hart commented 3 years ago

Pull request 27 fully removes the tools/miniconda installation artifacts.

jmunroe commented 3 years ago

I had a need to go through the install instructions again this morning and was completely successful. Issue look to be resolved and may be closed. Thanks!