Limit points in timeseries plot

DFO-Ocean-Navigator / Ocean-Data-Map-Project

The Ocean Navigator is an online tool that is used to help visualise scientific research data. a users guide is available at https://dfo-ocean-navigator.github.io/Ocean-Navigator-Manual/ and the tool is live at

http://navigator.oceansdata.ca

GNU General Public License v3.0

50 stars 20 forks source link

Limit points in timeseries plot #1125

Closed JustinElms closed 9 months ago

JustinElms commented 9 months ago

Background

VM/Timeseries plot requests covering more than ~50 timestamps have historically taken longer than the 5 minute response time limit allotted to Navigator queries. In the past we have limited the timepicker components so that users cannot select timespans greater than 50 timestamps but this was dropped when the UI was refactored last year. Instead of taking a similar approach I opted to subsample the timestamps so than users can request timeseries plots over any length of time but the result plot will only have a maximum of 50 points.

Why did you take this approach?

Unlike the previous approach described above, this allows users to plot any length of timeseries.

Checks

[X] I ran unit tests.
[X] I've tested the relevant changes from a user POV.
[X] I've formatted my Python code using black ..

sentry-io[bot] commented 9 months ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: data/netcdf_data.py

Function	Unhandled Issue
`get_nc_file_list`	RuntimeError: NetCDF file list is empty. /api/v2.... `Event Count:` 49
`get_nc_file_list`	RuntimeError: NetCDF file list is empty. /api/v2.... `Event Count:` 5
`get_nc_file_list`	OperationalError: unable to open database file /a... `Event Count:` 1

_{Did you find this useful? React with a 👍 or 👎}