DFOnline / CodeClient

A DiamondFire utility client for advanced coding.
MIT License
12 stars 8 forks source link

NBT Editor crashed when tooltips are displayed outside of a menu #65

Closed JayRPlayz closed 3 months ago

JayRPlayz commented 7 months ago

every time i try to go in dev

i dont know the cause :(

GeorgeRNG commented 7 months ago

please upload crash logs

JayRPlayz commented 7 months ago

rei.log rei-issues.log latest.log here are the three logs, btw i think its caused by "roughly enough items"

JayRPlayz commented 7 months ago

nvm, rei isnt the problem rei-issues.log latest.log rei.log

GeorgeRNG commented 7 months ago

Does the issue stop happening when you uninstall nbteditor?

JayRPlayz commented 6 months ago

it doesnt crash without nbt editor, is there a fix? because i really want to use nbt editor, and the previous versions work with nbt editor, but dont work with IBE editor

GeorgeRNG commented 6 months ago

Okay, I've identified the issue. nbt editor doesn't like tooltips (from chest peeker, seeing signs which are too long and signs from behind) outside of screens. It's an NBT Editor issue at https://github.com/mega12345mega/NBT-Editor/issues/56 However, as mega12345mega says:

In the meantime, I believe if you disable "Tooltip Overflow Fix" in the /nbt config screen, the crash should stop. The disadvantage is that this will make images imported as item lore basically impossible to view if they are not at a tiny resolution.

JayRPlayz commented 6 months ago

ok, thx!

JayRPlayz commented 6 months ago

i dont need tooltip overflow fix anyway

mega12345mega commented 5 months ago

I've now fixed this in v1.13.0, so I think this can be closed. Sorry for the inconvenience! (Technically I only tested with the EssentialsGUI mod mentioned in the issue on my repo, so you might want to check just to be sure.)

GeorgeRNG commented 5 months ago

tyvm, I'll testing that on our mod then

RedVortexDev commented 3 months ago

As mentioned in the NBT Editor issue, this has been resolved in v1.13.0. This issue can be closed.