search

DFRobot / pxt-maqueen

Maqueen is an easy-to-use programming educational Robot
https://dfrobot.github.io/pxt-maqueen/
MIT License
42 stars 102 forks source link

Update Japanese locale #34

Closed shogenji closed 1 year ago

shogenji commented 2 years ago

This update will improve the Japanese locale.

shogenji commented 2 years ago

The previously merged PR improved the Japanese locale. But also, I believe that this update will make it better.

In the line 31 of ja/maqueen-strings.json, "maqueen.ltEvent|block": "ラインセンサーの|%value|が|%vi|のとき", Incorrect translation.

In the line 14 and 15 of ja/maqueen-strings.json, "maqueen.Voltage.High|block": "白", "maqueen.Voltage.Low|block": "黒", Too much translated for educational purposes. The line tracking sensor is not detect black and white. It detect if IR reflected or not. The sensor can also be used to detect whether there is a floor. Also, "maqueen.readPatrol|block" returns 0 or 1.

T-Sa-sa-ki commented 2 years ago

For example, in ru/maqueen-strings.json,

22 "maqueen.Voltage.High|block": "белый", 23 "maqueen.Voltage.Low|block": "чёрный",

"белый" in Russian means White. "чёрный" in Russian means Black.

Of course, if we translate the language strictly, this is not accurate. However, it is better to think about what kind of translation would be more effective for children's learning.

On the other hand, the following is a comparison of the previously merged Pull Request and the current one.

The only difference is whether Parentheses and Colon are double-byte or single-byte characters. There are so many trivial fixes like this. It is highly questionable what positive effect these differences will have on children's learning. While ​I agree with this person's enthusiasm for the accuracy ​translation, I think it should ​be gradually perfected as it is used in a real learning environment.