Icon File doesn't work on macOS

PlasmaSoftUK commented 6 years ago

Minor gui issue but as per title the .ico in Resources folder doesn't work on MacOS needs to be a .icns file.

ouki-wang commented 6 years ago

@PlasmaSoftUK uPyCraft is only used in the enviroment os 10.11 Python3.5 PyQt4 now, the source code is https://github.com/DFRobot/uPyCraft_src for your reference. Well, we cannot judge the problem comprehensively only from your description above. Maybe you can try send a screen shot.

PlasmaSoftUK commented 6 years ago

Ok, let me see if I can explain this a bit better with a picture.

On macOS the 'uPyCraft' App Icon doesn't show up. It has the plain default 'no icon' picture. But if you look inside "uPyCraft/Contents/Resources/" there is a "logo.ico" which is the correct place for the logo on macOS however it needs to be an IconSet called "logo.icns" and correctly referenced from the "info.plist" in Contents.

[EDIT] I've just created a .icns file from the .ico file and modified the info.plist to reference it instead, this has resolved the problem. Happy to share the .icns if it helps. [/EDIT]

jhlucky commented 6 years ago

Thank you for your replying, I will debug it two days later. You must be right. The next version will be uplaoded after debugging.

todocono commented 5 years ago

This bugs still exists

OptimusGREEN commented 4 years ago

and still exists...

DFRobot / uPyCraft

Icon File doesn't work on macOS #17