Can't login with Zach Modal on iPhone

DFTi / Scribbeo

Scribbeo on iOS (Available on App Store)

1 stars 0 forks source link

Can't login with Zach Modal on iPhone #14

Closed kfatehi closed 12 years ago

kfatehi commented 12 years ago

The keyboard covers up the bottom portion of the form, in portrait and landscape so that you can't enter the info.

mixflame commented 12 years ago

effectively closed. Zach Modal is done

mixflame commented 12 years ago

notes:

this has been patched to:

never display ZachModal
preload ZachModal with the correct info from IASK securely never leaking password
attempt to login as soon as 401 is received from the server

this all has the effect of making it seem like login is done though IASK (Settings.app)

mixflame commented 12 years ago

fixxxed in master

kfatehi commented 12 years ago

So you kept his code but just monkeypatched it to preload and not display? I'm curious to know why you though this strategy was better than to remove it entirely, cutting all the fat (rather than just hiding the fat)

kfatehi commented 12 years ago

I think the most useful part of that SBServerLoginVC class is this: (void)serverLoginAttempt:(UIBarButtonItem*)barButtonItem

kfatehi commented 12 years ago

Also I wonder what happens now if your username or password is incorrect.