DFabric / DPlatform-Shell

Deploy self-hosted apps easily: simple, bloat-free, independent installation
https://dfabric.github.io/DPlatform-Shell
MIT License
271 stars 44 forks source link

Fixing Syncthing installation #35

Closed ghost closed 7 years ago

ghost commented 7 years ago

(1) Got an error starting the service because the working directory was empty, is now set to the user path. (2) Also got an error while starting the service because the config needs a full path.

j8r commented 7 years ago

Thanks for your PR! Little collaterals changes are needed before merging.

ghost commented 7 years ago

I know that a different service is being moved from the repo, however my system uses the ones in /etc, and moving the ones of the repo there doesn't work either.

j8r commented 7 years ago

Ok no problem we can keep this created service. However, we should do some clean up on the script as commented above on the file.

j8r commented 7 years ago

You don't have to use sed command, look at the end of CONTRIBUTING.md:

 # Add systemd process and run the server
sh sysutils/services.sh MyApp "/usr/bin/node /usr/bin/MyApp" /home/myapp/MyApp myapp
# This command with its arguments correspond to
# sh ServiceCreationScriptPath ServiceName "ExecStart=" WorkingDirectory= User=

Thus we only need to modify the line 60. The last argument that correspond to User= isn't needed here.

j8r commented 7 years ago

Thanks for you contribution @Datenschutz .