DFortun81 / AllTheThings

ALL THE THINGS - Addon for Tracking Collections & Account Completion in World of Warcraft
Other
120 stars 76 forks source link

DF-3.12.4 - Bronze tooltip no longer showing up #1649

Closed Protuhj closed 1 month ago

Protuhj commented 1 month ago

Just updated to DF-3.12.3 and the tooltip for Bronze no longer shows up. I didn't change any ATT settings.

There are no errors in BugSack.

I downgraded to DF-3.12.2 just to verify that still worked, and it does.

image

ShadowBrooks commented 1 month ago

Does it work in 3.12.4 for you?

Protuhj commented 1 month ago

No, it's still broken.

Protuhj commented 1 month ago

Note: the tooltip IS being modified by ATT, but the summary of what I can buy, and estimated amount to buy everything (like with other currencies/items) no longer shows up.

Protuhj commented 1 month ago

https://github.com/DFortun81/AllTheThings/commit/65a978a7aa58e2977aa766b720dc7ddbb35e0e8f#diff-402380fae67c170f8d42721cafb070d81e143958266633f158dd52a0cc6800f0

This is the commit that "broke" it. I changed line 565 to be [2778] = 0, -- Bronze and it works how it previously did.

What does "...unless within a popout" mean?

ShadowBrooks commented 1 month ago

Type into chat /att and then shift click the bronze and it should link in chat and create a att popup window. Likely the change was made from a performance standpoint, other currencies/items list less than 100 "things" with bronze its 2000+ so for lots of users they could have issues with it automatically displaying on mouse over.

Protuhj commented 1 month ago

Where in the ATT list is Bronze?

Nevermind, it's under "Create Dynamic Categories"

Edit: Also had to right click bronze instead of shift-clicking. I'll close this, since it was intended for performance improvement.

Protuhj commented 1 month ago

Closing this since it was done intentionally for performance reasons.

ShadowBrooks commented 1 month ago

~Where in the ATT list is Bronze?~

My comment was directly related to your first screen shot, shift clicking an item will link it in chat like with any item in game. typing /att infront of that item link will generate a popout

Protuhj commented 1 month ago

I honestly had no idea that was a thing, thanks for that info!

I stuck that in a macro to get the info I previously was using the tooltip for, so really thanks for that.