search

DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
47 stars 39 forks source link

ATE v10 changes #191

Closed kaelad02 closed 1 year ago

kaelad02 commented 1 year ago

Update the _createAtlEffectKey function to have v9 and v10 sections. I also removed the existing ones that weren't renamed in v9. While ATL.dimSight and ATL.brightSight aren't used anymore, they aren't a simple rename so it's probably better that we use the new keys directly. That's why I made the change I did to Darkvision, plus adding the new visionMode in there as well.

DFreds commented 1 year ago

Hm, so there isn't actually any reason at all to support v9 things. Foundry makes it hard to support both with their recent changes.

I think the whole _createAtlEffectKey function could probably be removed in favor of just using the correct key in the effect definitions now. Do you want to make that change? Otherwise, I can merge this and do it myself.