DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
47 stars 39 forks source link

V11 can not create new Effects #251

Closed DesertEagle50 closed 1 year ago

DesertEagle50 commented 1 year ago

Describe the bug creating a new effect gives an error. "Cannot set property statusId of # which has only a getter"

To Reproduce Steps to reproduce the behavior:

  1. Go to CE
  2. Click on "create effect"
  3. change the title. hit "submit changes"
  4. See error

Expected behavior Should create a new CE.

DFreds commented 1 year ago

I'm not actually seeing this occur. Is there any more info in the console?

Is the world one that migrated from v10? It could be that it can't update the underlying CE item, which I might be able to resolve. Maybe try on a brand new world to see if that narrows it down. I would also appreciate if you could send me the world as a zip or something.

DesertEagle50 commented 1 year ago

Yes a migrated world. I'll try with a new blank world. I'll see if I can upload the world. I'll 7zip it.

DFreds commented 1 year ago

Perfect, I appreciate that.

nyxalteria commented 1 year ago

Can confirm I have the error on a migrated world in 11.300 image It still appears on the list as created but I'm unsure of what kind of impact the error will have on it. image

nyxalteria commented 1 year ago

Just tested it in a newly created world, it doesn't throw the error, its an issue with migrated worlds.

DFreds commented 1 year ago

Okay, that's what I figured. It seems like it might be an issue with Dynamic Active Effects (DAE) anyway based on that console log.

I am unsure why it's doing it... but if creating an effect still works and allows you to customize it and use it, then the error can probably be ignored. DAE will have to update to avoid using statusId, which was removed in v11.