search

DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
45 stars 39 forks source link

Reaction is not ending at start of turn in v11 #254

Closed YenBenGrey closed 1 year ago

YenBenGrey commented 1 year ago

Describe the bug Reaction is not dropping off at start of turn in v11

To Reproduce Steps to reproduce the behavior: Set up combat Attack not on your round Reaction icon appears on token and effects panel At start of turn it stays there.

Expected behavior Reaction should end at start of turn

Additional context Not sure if this is related to other CEs that MidiQol relies on, however the difference is that when reaction is supposed to drop off, it stays and the little time symbol in effects panel is white as if it is still live. Whereas with concentration or any other effect, when it runs out the icon in effects panel turns yellow and when hovered it says that the effect has expired.

YenBenGrey commented 1 year ago

Concentration seems to be working perfectly well now.

The reaction problem persists. Only in v11, in v10 it drops off as it is supposed to.

Also when I make a custom version of Reaction, there is no duration. Not looked at it in v10 yet. Not sure if that makes a difference.

YenBenGrey commented 1 year ago

It turns out I didn't have Times Up on. I am so sorry if I took up any of your time. I thought it was a dependency and auto turned on. :-(