DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
45 stars 39 forks source link

NaN when applying exhaustion #272

Closed Aavar6802 closed 1 year ago

Aavar6802 commented 1 year ago

Foundry v11.306, DnD5e v2.2.2, DFCE v5.0.3

Describe the bug Applying exhaustion via the Token Status Effects causes modifiers and AC to appear as NaN (See photo).

To Reproduce Steps to reproduce the behavior:

  1. Left click token.
  2. Click "Assign Status Effects"
  3. Select any level of exhaustion.
  4. See error

image

thatlonelybugbear commented 1 year ago

Hello again, do you still use the "Rolldata Aware Active Effects" you mentioned here? https://gitlab.com/tposney/dae/-/issues/394#note_1483440490

Aavar6802 commented 1 year ago

No, it has been removed.

Aavar6802 commented 1 year ago

I deactivated all modules and reenabled everything individually. I am not able to replicate the issue after doing this.

The issue now is that ability checks are not flagged as having disadvantage. I am not sure if this is a DAE, Midi, or DFCE issue. image

DFreds commented 1 year ago

The ability check disadvantage part is provided by midi when it rolls. Foundry has no native way to do that, so I'm just adding the midi flag to tell midi it should (the second entry in the image). In any case, if you can't reproduce it anymore, I'm guessing it was a conflict so I'll close this until further notice.