search

DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
44 stars 37 forks source link

Some Mechanism to Stack Effects from Menu #279

Open crcoughenour opened 1 year ago

crcoughenour commented 1 year ago

Is your feature request related to a problem? Please describe. When used in conjunction with DAE's Stackable effects, it would be nice to be able indicate if we wish to add or remove the clicked effect. Currently, the effect is removed if present and added if not present. I suppose even without DAE this could be useful when operating on large numbers of tokens where some have an effect and some do not.

Describe the solution you'd like I would like any way to choose between adding and removing an effect from the menu. Perhaps modifiers like ctrl and shift could be used to indicate add or remove when clicking.

Describe alternatives you've considered The current point-and-click workaround is to use Status Icon Counters + effects increase stack count by 1 (DAE) + a Custom Token Status Effect (DFreds CE) and then from the token hud you can left click to add and right click to remove stacks. Obviously, this approach isn't bulkified and it can bloat the number of Status Effects more than necessary.

IggydB commented 1 year ago

Is your feature request related to a problem? Please describe. When used in conjunction with DAE's Stackable effects, it would be nice to be able indicate if we wish to add or remove the clicked effect. Currently, the effect is removed if present and added if not present. I suppose even without DAE this could be useful when operating on large numbers of tokens where some have an effect and some do not.

Describe the solution you'd like I would like any way to choose between adding and removing an effect from the menu. Perhaps modifiers like ctrl and shift could be used to indicate add or remove when clicking.

Describe alternatives you've considered The current point-and-click workaround is to use Status Icon Counters + effects increase stack count by 1 (DAE) + a Custom Token Status Effect (DFreds CE) and then from the token hud you can left click to add and right click to remove stacks. Obviously, this approach isn't bulkified and it can bloat the number of Status Effects more than necessary.

Just a query on your workaround. How did you manage to get an effect to properly react to the counter from Status Icon Counters? My Status Effect completely ignores the counter so I'm wondering what you are referencing in your effect?

crcoughenour commented 1 year ago

Just a query on your workaround. How did you manage to get an effect to properly react to the counter from Status Icon Counters? My Status Effect completely ignores the counter so I'm wondering what you are referencing in your effect?

Short answer: I don't think it works.

I think the only one I have that actually uses the stack count for any math or function is a Bleed effect using Midi QoL's OverTime effects which does somehow know 2 stacks deals twice as much damage and so forth. Otherwise all of my other use cases don't have any math or automation, I just want to know how many stacks someone has and we do the rest manually.

Effects on items can use ##stackCount though, but I assume that wasn't the question.