Closed thatlonelybugbear closed 11 months ago
Might also need a meta key option if the client is Apple based, but not sure how to implement that.
Cool stuff. Honestly, I don't really see the point of explicitly letting them choose what key would open it. Could probably just go with shift left-click always, and state as such in the setting as well as the hover text. That's my one overall suggestion. Thoughts?
I'll review what you have though.
Reviewed, some minor things. Make sure to format with prettier as well.
Also, I could probably be convinced this should just be the default behavior without any settings. But maybe too breaking of a change
Will take a stab at these later. My initial version had only an on/off setting for using the Shift + LMB combo. So I will just revert to that one.
This is a personal preference to save sidebar buttons real estate, which you might find interesting. It breaks Foundry convention of one sidebar button one function, so it is totally understandable if this isn't implemented in the end 👍
Note: It has some mentions to additions made in the https://github.com/DFreds/dfreds-convenient-effects/pull/282 , which even though not breaking, might be a bit conflicting.
game.user.role