Add the option for a unified app button, for both the Convenient Effects app and the Remove Effects app.

thatlonelybugbear commented 1 year ago

This is a personal preference to save sidebar buttons real estate, which you might find interesting. It breaks Foundry convention of one sidebar button one function, so it is totally understandable if this isn't implemented in the end 👍

Note: It has some mentions to additions made in the https://github.com/DFreds/dfreds-convenient-effects/pull/282 , which even though not breaking, might be a bit conflicting.

Remove the secondary button added by DFreds remove effects app and using an event to open it if needed.
Add a World setting for choosing to unify the buttons and choose the relevant key to use alongside left mouse click to open the remove effects app.
Will respect the settings for visibility of the apps based on game.user.role

thatlonelybugbear commented 1 year ago

Might also need a meta key option if the client is Apple based, but not sure how to implement that.

DFreds commented 1 year ago

Cool stuff. Honestly, I don't really see the point of explicitly letting them choose what key would open it. Could probably just go with shift left-click always, and state as such in the setting as well as the hover text. That's my one overall suggestion. Thoughts?

I'll review what you have though.

DFreds commented 1 year ago

Reviewed, some minor things. Make sure to format with prettier as well.

Also, I could probably be convinced this should just be the default behavior without any settings. But maybe too breaking of a change

thatlonelybugbear commented 1 year ago

Will take a stab at these later. My initial version had only an on/off setting for using the Shift + LMB combo. So I will just revert to that one.

DFreds / dfreds-convenient-effects

Add the option for a unified app button, for both the Convenient Effects app and the Remove Effects app. #283