search

DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
44 stars 37 forks source link

An attempt to expand the module to a multisystem view #289

Closed p4535992 closed 10 months ago

p4535992 commented 1 year ago

From a technical point of view, the idea is simply to create a class of "EffectDefinitions" for each system.

I started from the multisystem mechanism used by wasp for "item piles" and trying to touch as little code as possible.

thatlonelybugbear commented 1 year ago

~~It might make more sense for the CE to have a basic infrastructure to allow for a check of whether game.system.id is either dnd5e or sw5e and if not fire a Hook to allow for an integration module provided by users of these other systems, to populate the effect-definitions with their own~~🤔

OK yeah dont mind me 🤦 ... I need ☕

p4535992 commented 11 months ago

@DFreds Is there any problem with this PR ? Do you need me to do anything additional ?