search

DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
44 stars 37 forks source link

[Bug]Concentration spells not working #321

Closed EvldoaTV closed 1 week ago

EvldoaTV commented 5 months ago

getting this error with a number of spells like witch bolt, entangle and fairie fire since latest 5e update' the roll isnt completing in the chat cards

acttive-effect.mjs:426 Uncaught (in promise) TypeError: undefined. Cannot read properties of undefined (reading 'id') [Detected 1 package: system:dnd5e] at ActiveEffect5e.createConcentrationEffectData (active-effect.mjs:426:31) at Actor5e.beginConcentrating (actor.mjs:1112:33) at Item5e.use (item.mjs:1028:39)

disabled all other mods and found that CAE was the cause

DFreds commented 5 months ago

I need more info here... Specifically, how you were applying the spell and/or concentration. Via midi?

EvldoaTV commented 5 months ago

I need more info here... Specifically, how you were applying the spell and/or concentration. Via midi?

All other mods are disabled and only Dfreds is active, so the dnd5e system and dfreds are handling concentration. casting spell from character sheet which causes the above error, the spell doesn't produce a chat card, template or anything

I am using the new dnd5e, everything was working find until the most recent update to the 5e system from foundry disabling Dfreds and running all other mods everything works as intended

DFreds commented 5 months ago

Gotcha, thanks for clarifying. A fix is in the works

EvldoaTV commented 5 months ago

thank you for the reply look forward to a fix absolutely love your mod

lovethebomb commented 5 months ago

Thank you for working on this @DFreds !

For a quick fix meanwhile the bug is in the works:

You can still apply the effect with the Convenient Effects toolbar

The issue only happens because Replace does not take into account the new (3.x.x?) dnd system changes related to Concentration warnings before casting spells.

Lector commented 4 months ago

I am having the same issue. Thanks for fixing this in advance. Im already looking forward for the next update :)

Silcet commented 4 months ago

If you have a commit or a branch for testing I'd be glad to help in that regard. I have an instance I usually use to test upgrades before upgrading things in the FVTT server where we play our campaign, so it can be easily used for testing this fix.

Thanks for the workaround also @lovethebomb ❤️ 💣

AAUCrisp commented 2 months ago

How is this issue so late by now? I'm sad that I have to dissable DFreds Convenient Effects :( It's a nice module.

Is there a fix on the horizon?

Edit: was that thumbs down reaction a "no" or a "I don't like your comment"?

DFreds commented 1 week ago

As of v7, CE doesn't do anything with status effect IDs anymore. There is still a Concentration condition that midi should be able to use