search

DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
44 stars 37 forks source link

DND5E 2.4.1 Effect removed before combat #324

Closed vinnie2k closed 4 months ago

vinnie2k commented 4 months ago

Describe the Bug

When I set a custom effect on a PC, attacking removes the effect automatically.

Context

No errors on the console Foundry version = 11.315 System = DND5E 2.4.1 Browser = Microsoft Edge Hosting service = Molten

To Reproduce

Create custom effect called "Flanking" which sets flags.midi-qol.advantage.attack.mwak to 1 Create macro: "game.dfreds.effectInterface.toggleEffect("Flanking")" Use macro on PC (effect applied successfully) Target NPC Select PC attack (effect removed before roll)

Expected Behavior

I expect the attack to take the effect into account.

thatlonelybugbear commented 4 months ago

I imagine this has something to do with MidiQOL actually checking for Flanking.

What is your relevant setting set to, under MidiQOL settings > Workflow settings > Rules for Check Flanking?

image

vinnie2k commented 4 months ago

I had it on Convenient Effect Flanking Only which works perfectly for what I want. No need for an extra effect. Case closed. Sorry about that.