search

DFreds / dfreds-convenient-effects

A FoundryVTT module that adds easy to use toggleable active effects for any system.
MIT License
47 stars 39 forks source link

Covenient Effects is Adding Multiple of the Same Custom Active Effect #350

Open Shareenx opened 1 week ago

Shareenx commented 1 week ago

Module Version: 7.1.1 Foundry Version: 12.331 Game System D&D 5E Version 4.0.4 Effects Panel Version: 4.02 Browser: Chrome Version 129.0.6668.100 (Official Build) (64-bit) Other Modules Active: None

Describe the bug This has been going on for a long time. I had hoped updating to v12, and updating everything would make it go away. Alas, it is still here.

When a PC Actor (Does not seem to occur for NPC's), multiple custom Active Effects are applied. Just this one, though. "Hurt" (I have multiple custom effects) At one point I had DAE, Combat Utility Belt, Active Token Effects some or all going (testing and playing with modules). I am trying to find where DFred's Convenient Effects reads from to apply the Effects Automatically so I can go in and try to make it stop the multiple applications.

To Reproduce Steps to reproduce the behavior:

  1. Have a Custom Active Effect "Hurt" 0a. At some point, set it in a module somewhere so that it would trigger on HP < 0, to stack multiples. 0b. Go through Module, Foundry, Gaming System updates 0c. Everything is fine, do 0b several more times. 0d. One day-

Open a PC Character Sheet Click on the Current HP Type "-5" (or adjust manually to some number lower than the max) See error

Expected behavior Just one instance of the custom Active Effect "Hurt" to be applied.

Screenshots If applicable, add screenshots to help explain your problem. See below

Additional context I am certain some other module made some change to a config file flagging which Active Effects automatically should be applied. At one point I had DAE, Combat Utility Belt, Active Token Effects some or all going (testing and playing with modules). However, those modules either are deprecated, do not work, uninstalled, or inactive. Dfred's is the module applying the Active Effect automatically, so just would like to know where it is reading that from.

Attachment Descriptions Set HP to 40/ 45 Add_Hurt.log

1

Clear log, set HP back to max Heal_Up.log

2

Set name of the Active Effect to something else, Apply damage (Set HP to 40/45) Hurt_Effect_Missing.log

Pictures of the Active Effect Card

3 4 image image
DFreds commented 5 days ago

To be super clear here, Convenient Effects never apply automatically. There is nothing in the code base that supports any auto apply functionality on changes to an actor. This has to be caused by some other module that is not checking if something is applied first, or something. I really don't have a strong grasp of what you have set up here.

Shareenx commented 5 days ago

That's the weird thing. I did do stuff with CUB, or DAE, or other things in the (long) past, but disabled the modules and even uninstalled. The weirdest thing is that the Dev Console says Dfred's is doing it, automagically. Even with no other modules active. What I ended up doing is disabling the effects in Dfred's (if I delete them, a million errors pop up saying the effect is missing) What I am trying to figure out is what could be using DFred's to apply effects when nothing else is active. It's like something modified a Foundry config somewhere and is sneaky Pete applying stuff. Argh, I was hoping you had a clue what could be doing it, because something is using Convenient Effects to do this. Bah!