Typo in config_2017.cmd

DGA-MI-SSI / YaCo

YaCo is an Hex-Rays IDA plugin. When enabled, multiple users can work simultaneously on the same binary. Any modification done by any user is synchronized through git version control.

GNU General Public License v3.0

313 stars 36 forks source link

Typo in config_2017.cmd #12

Closed metal-crow closed 7 years ago

metal-crow commented 7 years ago

The build file configure_2017.cmd specifies the target as "Visual Studio 15 2017", which is not a valid target. Changing to "Visual Studio 15" fixes the error.

bamiaux commented 7 years ago

Which version of cmake are you using ? I cannot reproduce it

λ cmake --version
cmake version 3.8.2

λ cmake --help
The following generators are available on this platform:
  Visual Studio 15 2017 [arch] = Generates Visual Studio 2017 project files.
                                 Optional [arch] can be "Win64" or "ARM".

metal-crow commented 7 years ago

Using version 3.7.0, so i suppose 3.8 has changed the name of the generator. That's an unfortunate change, but i guess the build file is valid then.

bamiaux commented 7 years ago

Ok, I'll close this bug Anyway the various configure commands are just helpers, many people invoke cmake manually