search

DGA-MI-SSI / YaCo

YaCo is an Hex-Rays IDA plugin. When enabled, multiple users can work simultaneously on the same binary. Any modification done by any user is synchronized through git version control.
GNU General Public License v3.0
313 stars 36 forks source link

Build on Windows fails when there is a space in the path to YaCo #23

Closed fridtjof closed 6 years ago

fridtjof commented 6 years ago

Unfortunately I don't know cmake well enough to fix this in general because this occurs in a cmake file that is generated by configure_2017.cmd

Basically this is what goes wrong:

CustomBuild: Building Custom Rule C:/Users/Fridtjof Mund/Desktop/YaCo/build/CMakeLists.txt CMake does not need to re-run because C:/Users/Fridtjof Mund/Desktop/YaCo/out/x64/CMakeFiles/generate.stamp is up-to-date. yadb.fbs Generating yatools_/gitversion.dependency CMake Error at yatools/git_version.cmake:2 (execute_process): execute_process given unknown argument "Mund/Desktop/YaCo".

This happens for me because my user directory has a space in it, which is how Windows 10 decided to create it.

bamiaux commented 6 years ago

Reproduced & fixed in https://github.com/DGA-MI-SSI/YaCo/tree/fix_path_quotes Can you try it ?

fridtjof commented 6 years ago

Works! (after realizing a thing or two about quotes in env vars)