Constant set as size of struct aren't kept in YaCo

DGA-MI-SSI / YaCo

YaCo is an Hex-Rays IDA plugin. When enabled, multiple users can work simultaneously on the same binary. Any modification done by any user is synchronized through git version control.

GNU General Public License v3.0

313 stars 36 forks source link

Constant set as size of struct aren't kept in YaCo #34

Closed cbayet closed 6 years ago

cbayet commented 6 years ago

Hello,

It appears that when a constant is set in IDA as being the size of the struct it is not save in YaCo and when closing and re-opening the database it is lost.

An example will be: add eax, 20h becoming add eax, size MyStruct . But when closing the IDA database and reopening it, it came back to being add eax, 20h .

We did not investigate where the problem came from.

bamiaux commented 6 years ago

I cannot reproduce it with 1.8.2 and IDA 7.1. Pressing "t", selecting a size, saving, re-opening keep the size applied

cbayet commented 6 years ago

Hi,

We didn't managed to reproduce it in a controlled environment either, so I close it for now and maybe we will retrieve the error case later.

Sorry for the fail