search

DGA-MI-SSI / YaCo

YaCo is an Hex-Rays IDA plugin. When enabled, multiple users can work simultaneously on the same binary. Any modification done by any user is synchronized through git version control.
GNU General Public License v3.0
313 stars 36 forks source link

Adding the option to choose IDB tracking #41

Closed deadly-platypus closed 6 years ago

deadly-platypus commented 6 years ago

IDBs can be very large, and so are often difficult to maintain in a cloud based repository like GitHub. This pull requests adds the ability for the user to opt out of including the IDB file for versioning.

bamiaux commented 6 years ago

I will look at it next week

deadly-platypus commented 6 years ago

Regarding the menu option wording, is just changing the word IDB to Repo sufficient?

Regarding the checkbox, I'm not very good with UIs, so it might be faster if you know how add a checkbox. Feel free to modify my commits.

bamiaux commented 6 years ago

Ok, I'll test it later. About "Discard" and "Force push" I would just disable/remove them when the IDB is not tracked. It won't work great and you'll need to manage the IDB manually anyway About the GUI, it's too complex to go outside ask_yn & asktext, so let's forget more complex UIs ^^

deadly-platypus commented 6 years ago

yeah, but you could push or pull changes, and update the local IDB.

deadly-platypus commented 6 years ago

Plugin menus are now hidden if the IDB is not tracked.

bamiaux commented 6 years ago

Please try this updated version

deadly-platypus commented 6 years ago

Added my review. The changes don't break anything on my side.

bamiaux commented 6 years ago

Thanks for the pull request !

deadly-platypus commented 6 years ago

C'était sympa de coder avec vous!