search

DGA-MI-SSI / YaCo

YaCo is an Hex-Rays IDA plugin. When enabled, multiple users can work simultaneously on the same binary. Any modification done by any user is synchronized through git version control.
GNU General Public License v3.0
313 stars 36 forks source link

Function signature changes not applied to the db #51

Open Gericom opened 6 years ago

Gericom commented 6 years ago

I noticed that when a change is made to the function signature (args or return type), either through the type declaration dialogue (Y key) or through the decompilers "rename lvar" on an argument, this change is saved to one of the xml files, but is not applied to any of the other users db's, leading to inconsistencies.

bamiaux commented 6 years ago

This is weird, I think there is a test on this. I'll check next week. Is there any error message in the log file ?

Gericom commented 6 years ago

I checked the log, but there don't seem to be any error messages, or anything suspicious in there.

bamiaux commented 6 years ago

Sorry, I have not been able to reproduce it. I will push a patch tonight, containing a test checking changing one argument or the return type and it is correctly applied. Maybe you can give me a way to reproduce it, or, ideal case, change my test to trigger your bug ?

bamiaux commented 6 years ago

@Gericom Your bug could have been from missing local type, which have been fixed in https://github.com/DGA-MI-SSI/YaCo/issues/49

Gericom commented 6 years ago

I'll check later (when the new release comes out)

bamiaux commented 5 years ago

You can try https://github.com/DGA-MI-SSI/YaCo/releases/tag/v2.4 It won't sync changes from hexrays decompiler though, but changing the type with "Y" should work else it's a bug