DGh0st / FLEXall

Another FLEX loader that can be activated using long press on status bar or long three finger press anywhere.
58 stars 16 forks source link

Causes lockscreen to hang for several seconds after every sbreload. #3

Closed 0cyn closed 3 years ago

0cyn commented 4 years ago

Removed every tweak from my phone except for this one, issue remained. Issue persists across all devices tested upon.

How to replicate:

  1. Install this tweak
  2. sbreload
DGh0st commented 4 years ago

Hm, not seeing it on either of the devices I have (iPhone 6+ iOS 12.4.3 and iPad 6 iOS 13.4.1, both on Checkra1n).

What version of libFLEX are you using? What jailbreak are you using? lets hope this isn't jailbreak specific.

Code wise there isn't much that is run during bootup/respring/sbreload. There is a bunch of gesture creation but none of that should be blocking the main thread. My guess for pre-libFLEX 4.0 would be -[FLEXObjectExplorerViewController possibleExplorerSections] hook but thats not something that should hang for long if at all. Rest of the hooks are manage objects on the same thread without blocking so I am not seeing anything that could cause this.

0cyn commented 4 years ago

I've noticed it on both of my phones, with every Flex tweak i could find. 13.3 and 13.4, both X w/ Checkra1n.

I wonder if it could have anything to do with libflex itself or something large being loaded into it.

With only libFlex/FlexAll installed, it hangs for about 4-5 seconds.

With FlexAll and Flexy (my crap fork) installed, it hangs for about 9-10 seconds. the long hang is likely due to the symbol collision issues, as oslog gets filled with info about it.

With only Flexy (my fork, classes bundled) installed, it hangs for 2-3 seconds.

With nothing installed, the sbreload is instantly responsive.

DGh0st commented 3 years ago

As discussed on discord, made libFLEX only load on first gesture recognition in the late-loading branch. As I wasn't seeing the original issue, going to rely on you to verify whether that fixes it or not.

0cyn commented 3 years ago

Issue resolved with commit f350715 in branch late-loading