DGh0st / HSWidgets

Add options to display widgets right on your homescreen.
MIT License
37 stars 12 forks source link

Fix editing state bug and Zenith support #1

Closed Muirey03 closed 5 years ago

Muirey03 commented 5 years ago

Thinking about it now, loading Zenith first is unnecessary. My original logic behind it was that Zenith hooks setIsEditing too so that when you press and hold on a open stack, the rest of the icons don't go into editing mode, just the icons in the stack. Zenith achieves this by not calling %orig in setIsEditing so I thought you should load Zenith first so that your hook takes precedence over Zenith's meaning the notification would always be posted by HSWidgets, even if a zenith stack was open. Thinking about it now, you don't really want to broadcast the notification when a zenith stack is opened as the rest of the icons (including your widgets) aren't being edited. Feel free to remove that call to access and dlopen then.

Also I like to include all necessary files so that if other people want to compile it and they don't have the files included by default, it still works for them, but now we've decided that we don't need to load Zenith, you can remove those includes.

No other issues with the pull request I presume?