Miscellaneous details

[isivigno]

Dear all,

When preparing a lab session for DGtal (and digital geometry) beginners, I made a list of a bunch of details that could make the first steps in DGtal easier. Thus, here they are… It concerns very basic stuff, and I could do the modifications with your approval.

See you, Isabelle.

Uniformization

• different names are used here and there to refer to a digital set, for instance :
  • « set » in the function SetFromImage
  • « PointSet » as an attribute of a Digital Object
  • « DigitalSet » most of the time This is confusing where searching digital set related functionalities in the doc. I think it would be nice to use DigitalSet everywhere
• lowerBound() vs. getLowerBound()
  • in HyperRectDomain, DigitalSetDomain, and KhalimskySpaceND, the method is called « lowerBound »
  • seems to be « getLowerBound » everywhere else
• order of the arguments: in the three following methods extractAll2DSCellContours extractAllConnectedSCell extractAllPointContours4C put the arguments in the same order, for instance : result, KSpace, surfelAdjacency, point predicate. (extractAllPointContours4C is not consistent with the other two)

Miscellaneous

• The methods extractAll2DSCellContours and extractAllConnectedSCell output a vector< vector ..> but in order to fill a contour using the uFillInterior method, a set of surfels is required (need of a « find » member function). It could be nice to be able to output directly a vector < set ….> from the extraction.
• It would also be since to have a method to fill a closed contour and get a digital set as a result instead of an image.

[dcoeurjo]

thanks a lot isabelle for the feedbacks.

[kerautret]

thanks, I will look it but more after 0.9.3 ;)