Open dcoeurjo opened 5 years ago
I confirm ;(
Can one of you test to replace std::max_element
by boost::first_max_element
that is available in boost/algorithm/minmax_element.hpp
?
It is a proposed fix from https://github.com/boostorg/graph/issues/175 even if it will not solve the fact that DGtal::ConstIteratorAdapter
is not strictly a forward iterator.
thanks @rolanddenis I look it
@rolanddenis excellent that fix it 🎉 Did I put in PR the change ?
Thx, agree for the PR !
BTW I was more thinking in replacing by the boost version only where needed (with smart iterators like ConstIteratorAdaptor
), so probably only in:
examples/geometry/volumes/distance/toricdomainvolumetric.cpp
examples/kernel/examplePointFunctorHolder.cpp
examples/tutorial-examples/shapeDTViewer.cpp
examples/tutorial-examples/volDTGranulo-template.cpp
examples/tutorial-examples/volDTGranulo.cpp
We may also add a note in the ConstIteratorAdapter
documentation (I don't think there is a way to make it a true forward iterator...)
Yes agree I do it thanks
On the last apple clang compiler, the following code raises a build error
https://github.com/DGtal-team/DGtal/blob/c0b08384ff210fb33fb0f1067994457b3837eb9d/examples/geometry/volumes/distance/toricdomainvolumetric.cpp#L119
Here you have the error: