DGtal-team / DGtal

Digital Geometry Tools and Algorithm Library
https://dgtal.org
GNU Lesser General Public License v3.0
370 stars 115 forks source link

Display3D is restricted to Z3i::Space and Z3i::KSpace #687

Closed JacquesOlivierLachaud closed 10 years ago

JacquesOlivierLachaud commented 11 years ago

There are a few type issues in Display3D which impose the KhalimskySpace and the Space to use int32_t. For instance, in Display3D.ih

template < typename Space ,typename KSpace > inline typename DGtal::CanonicEmbedder::RealPoint DGtal::Display3D< Space ,KSpace >::embed( const DGtal::Z3i::Point & dp ) const { ASSERT( myEmbedder->isValid()); return myEmbedder->embed(dp); }

template < typename Space ,typename KSpace > inline typename DGtal::CanonicSCellEmbedder::RealPoint DGtal::Display3D< Space ,KSpace >::embedKS( const DGtal::Z3i::SCell & scell ) const { ASSERT( mySCellEmbedder->isValid()); return mySCellEmbedder->embed(scell); }

The methods embed and embedKS should take "typename Space::Point" and "typename KSpace::SCell".

kerautret commented 11 years ago

Yes right thank, I do it

kerautret commented 11 years ago

done

dcoeurjo commented 10 years ago

can this issue be closed?

kerautret commented 10 years ago

Yes sure ;) I close.