search

DGtal-team / DGtal

Digital Geometry Tools and Algorithm Library
https://dgtal.org
GNU Lesser General Public License v3.0
370 stars 115 forks source link

If QT4 not present (but cairo is) DGtalCairo does not compile #70

Closed dcoeurjo closed 13 years ago

dcoeurjo commented 13 years ago

because there is a dependency to QColor in DGtalCairo...

mtola commented 13 years ago

What do you want for the moment for this ? A new class ? The future-old Board/Color.h ? Tell me... Or you want to wait the new DGtal DGtalCairoBoard ?

dcoeurjo commented 13 years ago

I've assigned the wrong person... Bertrand and I discussed about a copy/clone of QColor in DGtal to remove the dependency to Qt when it's not needed

dcoeurjo commented 13 years ago

seems to be ok with Bertrand's Color

kerautret commented 13 years ago

Le 18/07/11 11:06, dcoeurjo a écrit :

seems to be ok with Bertrand's Color

Good news!

mtola commented 13 years ago

I'm not really sure it's a good idea to add five typedef DGtal::Color Color; in .h of Board...

I think it's better to change DGtalBoard::Color to DGTal::Color instead everywhere... and it will do the trick

What about that ?

kerautret commented 13 years ago

Yes it was first for testing, DGTal::Color is indeed good. I change it on the master.