DGtal-team / DGtal

Digital Geometry Tools and Algorithm Library
https://dgtal.org
GNU Lesser General Public License v3.0
370 stars 116 forks source link

Transformations of images rigid, affine, etc #813

Closed copyme closed 9 years ago

copyme commented 10 years ago

It will be nice to see these transformations in the near future in DGtal.

But probably is good to mention that right now I am working on rigid transformations and 3D images and my code uses DGtal, so I can redesign it a bit to get better compatibility with DGtal and also write a code for 2D. So far I have:

dcoeurjo commented 10 years ago

This would be indeed very interesting.. I also have bunch of code to port to DGtal related to Quasi-Affine Transforms (2d,3d). Please drop me an email if interested (private SVN repo).

copyme commented 10 years ago

First working version of 2D and 3D rigid transformation is here https://github.com/copyme/DGtal/compare/RigidTrans I still need to make some parts smoother, eg 3D transformation with Rodrigues formula which seems to me unreadable. And there is so far no a good and simple way to use for forward model for whole image. But it should not be used to offend therefore possible undefined values.

Main question is about the interface therefore may I ask about a small review of recent code (public API and easiness of use)? There are small examples which should show how to use this code. Thanks!

BTW Let me also know if you more prefer OpenCV like interface where one code returns transformation matrix and another apply it for points. Maybe this will be a more flexible solution.

dcoeurjo commented 10 years ago

Please do a pull-request as soon as you have everything (class+test+doc if necessary).. Branches are easier to follow in PR mode.

copyme commented 10 years ago

OK. I will do this soon. But right now there is a problem related to #865.

copyme commented 10 years ago

Quasi-Affine should appear soon (I started to work on them) but not before 0.8. Recently I am busy with writing a report.

dcoeurjo commented 9 years ago

Can I close this issue ? CC @copyme

dcoeurjo commented 9 years ago

ping @copyme, can i close this issue?

copyme commented 9 years ago

@dcoeurjo With shame I have to say I had no time to work on this issue. Let close it and if in the meanwhile I will have time to finish a port of your code I will re-open it.