Closed copyme closed 9 years ago
If you compile with the cmake variable WARNING_AS_ERROR to true (default is false), all warnings (unused, shadow, ..) will be reported as error. In travis, such mode is enabled, so examples should be free of such warnings (except if they have weird dependencies)
Would you have an example ?
Some examples:
DGtal/examples/topology/homotopicThinning3D.cpp:107:25: warning: declaration of ‘it’ shadows a previous local [-Wshadow] DigitalSet::Iterator it = Q.front() DGtal/examples/topology/homotopicThinning3D.cpp:81:24: warning: shadowed declaration is here [-Wshadow] DigitalSet::Iterator it, itE;
or
DGtal/examples/tutorial-examples/polyhedralizer.cpp:172:25: warning: typedef ‘SCell’ locally defined but not used [-Wunused-local-typedefs] typedef KSpace::SCell SCell;
It is ok know I guess...
Examples should be clear as much as possible.