DGtal-team / DGtal

Digital Geometry Tools and Algorithm Library
https://dgtal.org
GNU Lesser General Public License v3.0
370 stars 115 forks source link

SimpleThresholdForegroundPredicate not work neither with ConstImageAdapter and ImageAdapter #883

Closed kerautret closed 10 years ago

kerautret commented 10 years ago

SimpleThresholdForegroundPredicate not work neither with ConstImageAdapter and ImageAdapter.

For ImageAdapter it looks related to the fact:

@dcoeurjo what do you think? perhaps define a DefaultImageConstRange with DefaultImageRange for first pb. For the second pb, one can just specialized the template of SimpleThresholdForegroundPredicate with CConstImage

Let me know if you are ok since I can test it from a current example of use in 3DCurvatureViewer (for resampling functor).

dcoeurjo commented 10 years ago

For the second, ConstImageAdapter is a model of CConstImage, not CImage

Would you have an example of the thresholder not working with adapters ?

kerautret commented 10 years ago

"For the second, ConstImageAdapter is a model of CConstImage, not CImage" => Yes but by using it with SimpleThresholdForegroundPredicate there are an: BOOST_CONCEPT_ASSERT(( CImage )); http://liris.cnrs.fr/dgtal/doc/nightly/SimpleThresholdForegroundPredicate_8h_source.html

Yes: see: https://github.com/kerautret/DGtalTools/blob/bugSimpleThresholdForegroundPredicate/visualisation/3dCurvatureViewer.cpp

(but it use also PR #882 of DGtal

dcoeurjo commented 10 years ago

Yeah but I've fixed that in some PR...

dcoeurjo commented 10 years ago

843

kerautret commented 10 years ago

Nice ;) I miss it sorry! I check it now !

kerautret commented 10 years ago

I close It works ;) Thank you