search

DGtal-team / DGtalTools

Tools associated with DGtal Library
http://dgtal.org
GNU Lesser General Public License v3.0
44 stars 38 forks source link

Bugs in Contourgenerator and freeman2img Tools. #386

Closed lamaydt1986 closed 4 years ago

lamaydt1986 commented 4 years ago

Contourgenerator Tool: -g [ --gridstep ] arg (=1) Gridstep for the digitization -f [ --format ] arg (=pts) Output format: List of pointel coordinates {pts} Freman chaincode Vector {fc} -o [ --outputGeometry ] arg Base name of the file containing the shape geometry (points, tangents, curvature) Those options are still on the website doc while we are not able to use them anymore. -o now stands for --output( not outputGeometry) -f doesn't exist anymore it gives the coordinates of points by default and doesn't accept the fc option. -g is not recognize anymore. Freeman2img Tool: We need to precize the min value and max value ":img2freeman -i result.pgm --min 128 --max 255 > contours.fc" which is not written and described in the doc online.

kerautret commented 4 years ago

@lamaydt1986 Thanks I look it

kerautret commented 4 years ago

for contourGenerator, It looks fine for me: Capture d’écran 2020-09-12 à 15 26 41

Capture d’écran 2020-09-12 à 15 26 33

outputGeometry is well present (perhaps you miss it with shapeGenerator which is different) For img2freeman, perhaps no contours are given in your image included between 128 and 255 ? I just detect that "-o" is no more used, I change it in the big PR else it will gives conflicts.

kerautret commented 4 years ago

for img2freeman it is changed in upcoming PR in this commit: https://github.com/DGtal-team/DGtalTools/pull/373/commits/30361aa3648db575271d676b793afa7121a4baa8