search

DHARPA-Project / lumy

Modular research platform for digital humanities.
0 stars 0 forks source link

Correct notification modal backdrop #191

Closed dandybytes closed 2 years ago

dandybytes commented 2 years ago

The notification modal backdrop doesn't take up the full size of the content and looks odd when scrolling vertically.

This was probably caused by: https://github.com/DHARPA-Project/lumy/pull/165

Screenshot 2021-11-02 at 17 06 45

dandybytes commented 2 years ago

Giving the modal an absolute position inside of a lower-level element instead of the default top-level fixed position made the modal take up only the size of the initially rendered viewport and incapable of hoding its position when scroll or resize. The positioning and rendering hierarchy must be reverted for the modal to work properly.

dandybytes commented 2 years ago

Corrected in: https://github.com/DHARPA-Project/lumy/pull/194