DHBern / becher-frontend

https://dhbern.github.io/becher-frontend/
4 stars 2 forks source link

Footer Updates #5

Closed ZEDz318 closed 9 months ago

ZEDz318 commented 9 months ago

Removed unnecessary divs and classes Changed height of footer in small screens by changing grid cols from 4 to 2

ZEDz318 commented 9 months ago

I closed the last pr by mistake while syncing main Also, a couple of observations:

flicksolutions commented 9 months ago
  • It is fine to use "footer" in slot (to have footer be sticky), but the problem would be md screens, since both the footer and header are sticky, the content has very little space. I can have it sticky on sm and lg+ screens and static in md but it's not so straight forward and would be messy

just a remark: sticky is not the same as fixed here you mean fixed. It's fine how you decided here.

  • on sm screens, the content in the body is huge, thus (on the main page) it takes minutes to get to the footer if it's static

yes, this is a feature, not a bug. But I'm afraid if and when we're adding the Vikus-Viewer we might have to change to a paged-layout so we only show 30 items or so and then have a button there to load more.

  • it is not very apparent on larger screens, but when an item is selected, it's description page is initially focused on the footer

yes, this can be considered a bug. The scroll-position is kept the same after navigation. I will fix this later