Closed flicksolutions closed 2 months ago
why is the app in a subfolder of the repository? It complicates the structure, especially since you added another package.json. I'll add references to the code, so that you see what I mean:
https://github.com/DHBern/swiss-sculptures/blob/dee657c2f7ac1ee318dc171dcfa894f18cbe3ca1/package.json#L3 you added adapter-node here, but should've added it here: https://github.com/DHBern/swiss-sculptures/blob/dee657c2f7ac1ee318dc171dcfa894f18cbe3ca1/swiss-sculptures-map/package.json#L15
Please just move everything in the subfolder one layer up and get rid of the new files on this level created in https://github.com/DHBern/swiss-sculptures/commit/dee657c2f7ac1ee318dc171dcfa894f18cbe3ca1
thanks
why is the app in a subfolder of the repository? It complicates the structure, especially since you added another package.json. I'll add references to the code, so that you see what I mean:
https://github.com/DHBern/swiss-sculptures/blob/dee657c2f7ac1ee318dc171dcfa894f18cbe3ca1/package.json#L3 you added adapter-node here, but should've added it here: https://github.com/DHBern/swiss-sculptures/blob/dee657c2f7ac1ee318dc171dcfa894f18cbe3ca1/swiss-sculptures-map/package.json#L15
Please just move everything in the subfolder one layer up and get rid of the new files on this level created in https://github.com/DHBern/swiss-sculptures/commit/dee657c2f7ac1ee318dc171dcfa894f18cbe3ca1
thanks