search

DHI-GRAS / qgis-processing-gpf

QGIS Processing provider for GPF-based algorithms (BEAM and Sentinel-1 Toolbox)
GNU General Public License v3.0
2 stars 5 forks source link

Add files via upload #45

Closed ewamiti closed 6 years ago

ewamiti commented 7 years ago

Could you review this algorithm and add it to distribution ?

radosuav commented 7 years ago

Hi @ewamiti The algorithm itself looks good. However, there are some small issues in the pull request.

Firstly, the commit message should be changed to something more descriptive (e.g. Add NDVI operator). Secondly, the new file should be called NdviOp.txt and not SNAP_Ndvi.Op.txt, for consistency with already existing algorithms. And lastly, this file should be placed in snap_generic_description folder.

To fix those issues first rename the file and then move it to the required directory. Afterwards commit those changes to your repository. Then you can merge the old and new commit into one and fix the old commit message by running git shell and executing the following command: git rebase -i HEAD~2 In the text file that appears change the message of the first commit and the command of the second commit to fixup. Finally upload your changes to the pull request by running: git push -f