search

DHI-GRAS / react-components

React components we use in our frontends
MIT License
1 stars 0 forks source link

fix(styling):Remove Theming from components. Fix styling issues. #34

Closed bertearazvan closed 3 years ago

bertearazvan commented 3 years ago

This PR removes the ThemeProvider from every component in order for external theming to be applied. Removes the use of classes as it's not stable in production environments where the library is used.

Seems like the @material-ui library was getting bundled with the library and the regex expression was not doing the job. Added them manually.

The main issues with styling were happening because the library was bundling materialUI and generating classes that were overwritten by the external apps in production as the classname generator was generating the same class twice where in the library .jss1 had some styling and in external apps .jss1 had another styling.

You can read more about it here https://material-ui.com/getting-started/faq/

bertearazvan commented 3 years ago

:tada: This PR is included in version 1.9.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: