Concat bug with mikeio>2.0

DHI / mikeio

Read, write and manipulate dfs0, dfs1, dfs2, dfs3, dfsu and mesh files.

https://dhi.github.io/mikeio

BSD 3-Clause "New" or "Revised" License

139 stars 56 forks source link

Concat bug with mikeio>2.0 #718

Closed daniel-caichac-DHI closed 3 months ago

daniel-caichac-DHI commented 3 months ago

Hi,

I think there is an issue with generic.concat and dfs0 files at least. The documentation of generic.concat says that it should work with keep either first or last

But the documentation of _dataset.py says that it only works with last

Well, I am using generic.concat, and instead of calling generic.concat, it is going to dataset.concat apparently

Just tried with mikeio 2.0.0 and 2.0.1, same conclusion.
I downgraded to 1.7.1 and same script now works fine

ecomodeller commented 3 months ago

Thx for reporting this, the reason for this was that concatenating dfs0 files looping over every timestep is a bit slow. But I missed the fact that only one keep option was available.