Closed ecomodeller closed 3 years ago
dhitools seem to have a lot of useful functionality
Yes. The library is well maintained and well documented. So why copy? Just use it...
sorry, did not mean to close
Seems that https://github.com/robjameswall/dhitools could benefit from mikeio. But mikeio should avoid the GDAL and geopandas dependencies and not consume dhitools, or did you decide on something here?
I needed to load a dfs0, scale the time series data and write a new dfs0 file. I compiled @jsmariegaard 's github.com/DHI/dfs-utils instead and used from python. Maybe these tools can be merged as well?
GDAL and geopandas seems difficult to install via pip, and I don't want to make mikeio
only available via conda. Thus, I think we have to leave GIS functionality out of mikeio
.
Is there any other functionality from dhitools that we should include in mikeio
somehow? Or close this issue?
GDAL and geopandas seems difficult to install via pip
Only on Windows. On Linux there are by now zero issues with that (manylinux wheels galore).
Still, avoiding very heavy dependencies that are only needed for an isolated set of features is a great idea. You can still ease the interface to e.g. GeoDataFrames
, by returning dictionaries to directly create them from.
To qualify this discussion a bit more, I have tried to collect some important functionality in other mike libraries in the below lists. Please extend as needed. With such a list, we can prioritize what functionalities we would like to port to mikeio.
dhitools by robjameswall https://github.com/robjameswall/dhitools
DHI Matlab toolbox https://github.com/DHI/DHI-MATLAB-Toolbox
mikepy by Florian Monetti (DHI internal)
Nice. One way to prioritize could be to create an issue for each feature described with a few sentences and maybe with code snippets from the original source. If users and contributors really need these features then they will get implemented eventually or commented on in the issue. If there is a description there is a better chance someone might grab it. Maybe as part of a bigger related feature they are working on.
Implemented = ✔️ Notebook example = 📓
Implemented = ✔️ Notebook example = 📓
It is apparent that there is a lot of useful functionality in MIKE IO. I will close this issue and we can open more specific feature requests as the need arises.
dhitools seem to have a lot of useful functionality
https://github.com/robjameswall/dhitools https://pypi.org/project/dhitools/