search

DHI / modelskill

Compare results from MIKE and other simulations with measurements
https://dhi.github.io/modelskill
MIT License
33 stars 8 forks source link

Remove binsize argument from gridded_skill #395

Open ecomodeller opened 9 months ago

ecomodeller commented 9 months ago

The previous implementation missed parts of the data.

This PR removes this argument.

More explicit control over bins, use the bins argument with a list of bins.

jsmariegaard commented 9 months ago

I can't really make up my mind about this. Somehow I would like it to be like hist etc where you just have a single argument bins which can be different things. But most times you would actually want to specify just the binsize (which should be the same in x and y direction) e.g. 2 degrees formatted nicely so not -3.3, -1.3, 0.7, ... etc but -4, -2, 0, 2, ... The user can of course do this on their own...

ecomodeller commented 9 months ago

I can't really make up my mind about this. Somehow I would like it to be like hist etc where you just have a single argument bins which can be different things. But most times you would actually want to specify just the binsize (which should be the same in x and y direction) e.g. 2 degrees formatted nicely so not -3.3, -1.3, 0.7, ... etc but -4, -2, 0, 2, ... The user can of course do this on their own...

Sure, but in any case, they want the entire domain to be covered. Not skip some part to the right and the top...