search

DHI / modelskill

Compare results from MIKE and other simulations with measurements
https://dhi.github.io/modelskill
MIT License
33 stars 8 forks source link

Test compatability with older versions #414

Closed ecomodeller closed 8 months ago

ecomodeller commented 9 months ago

It is generally a bad idea to set limits on dependencies if most of the functionality works.

I have added a minimal version of pandas, same as xarray https://docs.xarray.dev/en/stable/getting-started-guide/installing.html#required-dependencies.

ecomodeller commented 8 months ago

The skill styling is the only thing that doesn't work with Pandas 1.4.

You can use styling if you convert it to a dataframe, thus good enough.

ecomodeller commented 8 months ago

[!NOTE] To remind myself How to test on older version of Python (which you probably don't have on your system) docker run -w /app -v$(pwd):/app -it --rm python:3.8-slim bash -c "pip install -r requirements_min.txt && pip install .[test] && pytest"