DHI / tsod

Anomaly Detection for time series data
https://dhi.github.io/tsod
MIT License
165 stars 18 forks source link

is_selected is not an argument #46

Open ecomodeller opened 1 year ago

ecomodeller commented 1 year ago

This errors appears when I try to upload a file image

The draft "solution" is to remove the is_selected.

Additional changes are due to formatting with black.

PaulDanielML commented 1 year ago

Seems like the E-charts python API changed. We can either pin its version to the previous one or just remove those options as you have done. The side effect of that might be performance issues when dealing with large datasets. I would have to find out what the new default value for the new "is_selected" option is. My guess would be "True".

PaulDanielML commented 1 year ago

Seems like the change was introduced in 2.0.3, so using 2.0.2 would be the easy fix. Problem is that this is a sub dependency of streamlit-echarts, which will just install the newest version. So let's just remove the argument for now, I can look up the way of achieving the same behaviour when things are a bit less busy.