search

DHRI-Curriculum / django-app

2 stars 3 forks source link

Image download issue #503

Closed kallewesterling closed 3 years ago

kallewesterling commented 3 years ago

I'm getting this error when I run "build" after pulling the most recent workshop updates.

File "/home/dhinstit/curriculum.dhinstitutes.org/backend/github.py", line 982, in _get_images_from_html raise NotImplementedError('This script does not yet download images as it should be synced in the repository.') NotImplementedError: This script does not yet download images as it should be synced in the repository.

I assume it's because someone somewhere added an image that links to an outside source (the "html" from the error message)? Or could it be because people are using relative vs absolute image links to the repo? I've seen both when reviewing the images so far. Please let me know if you think one of the above is the case here, and I will keep digging to find the culprit.

kallewesterling commented 3 years ago

@gofilipa it looks like I've found the error (which is not in the code but in the data-literacies code, where a https:/DHRI-... needs a correction.

I'm adding a better error message here that makes it easier to troubleshoot.

Here's what it looks like now:

NotImplementedError: Ran into an error while trying to copy into the static directory. This script does not yet download images as it should be synced in the repository. The following is the path for troubleshooting:

/Users/kallewesterling/Repositories/test/django-app/.loader-cache/workshops/data-literacies/https:/DHRI-Curriculum/data-literacies/raw/images/moSmall2_tidytogether.png
kallewesterling commented 3 years ago

@gofilipa I have opened a PR in data-literacies that will resolve everything for you. See here