DHedgecock / radical-vscode

A dark theme for radical hacking inspired by retro futuristic design.
https://marketplace.visualstudio.com/items?itemName=dhedgecock.radical-vscode
ISC License
68 stars 8 forks source link

Feedback: Editor Colors #15

Open DHedgecock opened 4 years ago

DHedgecock commented 4 years ago

Radical - Editor colors feedback

Hello, please feel free to provide feedback on the theme editor colors in this issue.

There are also tickets for:

sbaum1994 commented 4 years ago
Screen Shot 2020-08-19 at 11 28 27 AM

Passing along feedback from a friend - in typescript the contrast between white and cyan is a little hard on the eyes/not easy to differentiate

timendez commented 4 years ago

Specifically for a low-contrast setting on my monitor, which I use to reduce eye strain

1081 commented 3 years ago

Great Job with this Theme!!! Thank You!

Docstrings Python:

For my eye the docstrings in Python are to heavy, I made the changes below. I find the italic in the same color as the "function name" has still a nice contrast to the normal comments (also italic).

"editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": [
          "string.quoted.docstring.multi.python",
          "string.quoted.docstring.multi.python punctuation.definition.string.begin.python",
          "string.quoted.docstring.multi.python punctuation.definition.string.end.python",
          "string.quoted.docstring.multi.python constant.character.escape.python"
        ],
        "settings": {
          //"foreground": "#8ce1e7", // function names
          //"foreground": "#45898C", // comment
          "fontStyle": "italic"
        }
      }
    ],
  }

before:

Screenshot 2021-01-07 at 14 31 44

after:

Screenshot 2021-01-07 at 14 31 14

Cursor Color

I find it difficult to see the pink cursor over the pink rectangle around brackets.

It is much better visible in yellow clolor: ...but the pink cursor fits better to the overall design. 😕

Screenshot 2021-01-07 at 14 30 45

"workbench.colorCustomizations": { "editorCursor.foreground": "#ffff00", },

DHedgecock commented 3 years ago

@1081 thanks for the recommendations 👍 👍

I don't know Python, it looks like docstrings are for writing code documentation comments? The theme has a color for documentation comments that gets used in JS/TS files for JSDoc/TSDoc style comments. This seems like it matches. I'll make an update this weekend:

codestring

I'll also try to find a cursor color that stands out more and is alignment with theme.