search

DHendrixon / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #5

Open Emik234 opened 6 years ago

Emik234 commented 6 years ago

Project name: Dasmoto's Arts & Crafts Grade: Meets Expectations

Summary: Good job completing this project and submitting it on time! You have learned to work locally in your text editor and that is a big step. Your file structure was well organized and your heading hierarchy was coherent. You made great use of the price class to avoid redundant code and I liked your use of divs to give the page some added structure.

Your project was tidy and well-formatted throughout. For a more in depth look at best practices, I recommend reading through this chapter: http://learn.shayhowe.com/html-css/writing-your-best-code/

For future projects, you may want to download all images and use relative paths to link to them rather than absolute paths. While this isn’t strictly necessary, I do encourage it as new developers often struggle with directory structure at first and this is an important concept to get right. For more info, please read this section: https://internetingishard.com/html-and-css/links-and-images/#absolute-relative-and-root-relative-links

Finally, I encourage you to start thinking about web accessibility. This is something you will learn more about in week 7 but for a quick overview: ​https://www.codecademy.com/articles/accessibility

Overall, you did an excellent job here. Keep up the hard work!

DHendrixon commented 6 years ago

Thank you for the feedback. I look forward to continuing to learn through this program.

I was trying to push the changes I made to the project per your feedback back to this repo for review, but am unable to do so. Terminal gave the message "Updates were rejected because the tip of your current branch is behind its remote counterpart. Integrate the remote changes (e.g. 'git pull ...') before pushing again." Do you have insight in how to fix this? Or should I not worry about it at this point in the program?