search

DIAGNijmegen / pathology-whole-slide-data

A package for working with whole-slide data including a fast batch iterator that can be used to train deep learning models.
https://diagnijmegen.github.io/pathology-whole-slide-data/
Apache License 2.0
93 stars 27 forks source link

I got confused between branch 'main' and '0.0.16' #34

Closed BestVIncent closed 1 year ago

BestVIncent commented 1 year ago

When I use your project 'pathology-hooknet', there are many import issuses from wholeslidedata. For example, if I install wholeslidedata package with branch 'v0.0.16', the notebook in hooknet will report missing 'wholeslidedata/visualization'. But it does exist in branch 'main'. So I install wholeslidedata with branch 'main' instead, and it will report missing some functions in 'wholeslidedata/samplers/utils.py'. Maybe notebooks in hooknet have been outdate. I don't know how to fix it.

martvanrijthoven commented 1 year ago

Dear BestVincent,

Thank you for this issue report. Currently, wholeslidedata is transitioning to 0.1.0 (main branch), and indeed there were some incompatible issues with HookNetPracticalGuide.ipynb. I have fixed this now and the notebook should work again if you install wholeslidedata from the main branch:

pip install git+https://github.com/DIAGNijmegen/pathology-whole-slide-data@main

Sorry for the inconvenience. Please let me know if you run into more issues.

Best wishes, Mart