Closed MikeOver1 closed 2 years ago
Built in safety: tests will pass after https://github.com/comic/grand-challenge.org/pull/2575 has been merged.
It looks to be failing on a timeout error - what async task is being used? Is the worker that runs that task running in GitHub actions? https://github.com/DIAGNijmegen/rse-gcapi/blob/13225ecc7f2de0168a72c8673fe6814e9b629fa3/tests/conftest.py#L72-L79
It looks to be failing on a timeout error - what async task is being used? Is the worker that runs that task running in GitHub actions?
I think the timeout error is merely thrown because the display set has not been created. It fails for both the sync as well as the async test for adding new display sets, whereas the same construct works in other tests. I just merged in main to see if that makes a difference somehow.
public.ecr.aws/diag-nijmegen/grand-challenge/web:latest
should be up to date with gc's main branch right?
latest
currently points to public.ecr.aws/diag-nijmegen/grand-challenge/web:51cbaf7-main-ecdd7811
, sha256:f124c5b3cbf06767839987861a8c5b1e70a9480faf529799446a70f56eaed172
I get the same failures if I run this locally, running poetry shell
, pytest --lf --pdb
without having grand challenge already running (what CI does):
I can reproduce it locally now as well.
Closes #133
Note: to work properly, https://github.com/comic/grand-challenge.org/pull/2575 needs to be merged first.