Closed miriam-groeneveld closed 10 months ago
OpenSlide now supports DICOM, which I think is a much better solution than writng our own converter. These changes are not part of libvips yet. We can either:
I'll add an update once John Cupitt has replied, and just add the OpenSlide conversion if no answer by Monday.
I honestly think that building libvips
ourselves might be a better solution, especially because it seems clear that they will ultimately add the functionality. What I would do is to add the build-code right here in this repository so that rse-panimg still builds from sources. I can help with that if you want.
The disadvantage of adding openslide
is that we add another hard dependency that we need to maintain ourselves. If we only rely on libvips
our dependency graph stays leaner, with a short-term pain of having to maintain the build system.
Note: I built libvips in the past and know that it is not super-bad to do that. So I think that this is very much an option. Could probably get this working in a day or so...
From a functional/implementation side: adding openslide
directly is not a bad solution either of course!
We already use openslide for the other pathology > tiff conversions (like mrxs, vmu, etc.), so it wouldn't be a new dependency.
I wanted to come back at this one as well and say: Whatever, libvips
might be "ideal" but I am overthinking this again. And if we use it already, it is even better! :D
This PR became a mess, I opened a new one with at least a fix for the issue: https://github.com/DIAGNijmegen/rse-panimg/pull/104
Not every level was written with the correct data. Creating dzi files seems to have obfuscated the issue on GC.